lobsterparser: fix incorrect warning logic#13
Open
ondracka wants to merge 1 commit intonomad-coe:masterfrom
Open
lobsterparser: fix incorrect warning logic#13ondracka wants to merge 1 commit intonomad-coe:masterfrom
ondracka wants to merge 1 commit intonomad-coe:masterfrom
Conversation
Contributor
Author
|
CC @ladinesa |
Contributor
Author
|
I think this might have been forgotten... its really trivial. |
Collaborator
|
Sorry I missed this, can you please send me the test files? |
Contributor
Author
|
It is reproducible with the checked in test cases I even included some pytest testing. |
Contributor
Author
|
Hm, actually I see this was fixed by you in unrelated commit 069f068 already. |
Collaborator
I will keep this open and work on it when I get back. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just something I messed up in the last patch, the parsed results were OK, just a warning was printed when it shouldn't be so add also few simple tests to catch this in future.